Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6864][VL] Add a guard to prevent one Velox task from spilling another to conform to Velox's restriction #6865

Closed
wants to merge 1 commit into from
Closed

[GLUTEN-6864][VL] Add a guard to prevent one Velox task from spilling another to conform to Velox's restriction #6865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cpp/velox/compute/WholeStageResultIterator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,15 @@ int64_t WholeStageResultIterator::spillFixedSize(int64_t size) {
int64_t shrunken = memoryManager_->shrink(size);
// todo return the actual spilled size?
if (spillStrategy_ == "auto") {
exec::DriverThreadContext* driverThreadCtx = exec::driverThreadContext();
if (driverThreadCtx != nullptr) {
if (driverThreadCtx->driverCtx.task->taskId() != task_->taskId()) {
// Disallow one task from spilling another. This is by Velox's restriction. See
// https://github.com/facebookincubator/velox/blob/9523840ac329be4f7318338fb92cb92bcb0a8c07/velox/exec/Operator.cpp#L566-L575.
VLOG(2) << logPrefix << "One Velox task is trying to spill another, ignoring.";
return shrunken;
}
}
int64_t remaining = size - shrunken;
LOG(INFO) << logPrefix << "Trying to request spilling for " << remaining << " bytes...";
// suspend the driver when we are on it
Expand Down
Loading