Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove suspend section when spilling Velox task #6875

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Aug 16, 2024

Suspension is not needed during Velox updates. Remove it to minimize code.

…he request driver must be from the same task
…er and the request driver must be from the same task"

This reverts commit 774e48e.
@zhztheplayer zhztheplayer changed the title DNM: [VL] Remove suspend section in spilling DNM: [VL] Remove suspend section in Velox spill Aug 16, 2024
@github-actions github-actions bot added the VELOX label Aug 16, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhztheplayer zhztheplayer changed the title DNM: [VL] Remove suspend section in Velox spill DNM: [VL] Remove suspend section when spilling Velox task Aug 16, 2024
@zhztheplayer zhztheplayer changed the title DNM: [VL] Remove suspend section when spilling Velox task [VL] Remove suspend section when spilling Velox task Aug 16, 2024
@zhztheplayer zhztheplayer marked this pull request as ready for review August 16, 2024 03:15
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit 3b6924a into apache:main Aug 16, 2024
47 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
zhztheplayer added a commit to zhztheplayer/gluten that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants