[GLUTEN-6908][VL] Fix error when getting output from a Velox task that is under spilling by background thread #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… under spilling by background thread
zhztheplayer
changed the title
|
cc @FelixYBW |
|
rely on facebookincubator/velox#10600 |
FelixYBW
reviewed
Aug 21, 2024
FelixYBW
approved these changes
Aug 21, 2024
wForget
pushed a commit
to wForget/gluten
that referenced
this pull request
Oct 30, 2024
…t is under spilling by background thread (apache#6934) (cherry picked from commit 80078cd)
wForget
pushed a commit
to wForget/gluten
that referenced
this pull request
Oct 31, 2024
…t is under spilling by background thread (apache#6934) (cherry picked from commit 80078cd)
zsmj2017
pushed a commit
to zsmj2017/incubator-gluten
that referenced
this pull request
Nov 11, 2024
…t is under spilling by background thread (apache#6934) (cherry picked from commit 80078cd)
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…t is under spilling by background thread (apache#6934)
zsmj2017
pushed a commit
to zsmj2017/incubator-gluten
that referenced
this pull request
Nov 12, 2024
…t is under spilling by background thread (apache#6934) (cherry picked from commit 80078cd)
zhztheplayer
added a commit
to zhztheplayer/gluten
that referenced
this pull request
Nov 12, 2024
…t is under spilling by background thread (apache#6934) (cherry picked from commit 80078cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tends to fix #6908.
There is a state check to abort Velox / Spark task when Task::next is called on a task that is being paused and under arbitration. The patch fixes the issue by letting Spark wait on the future object returned by Velox task, and continue processing once spill is finished.
Rely on Velox change facebookincubator/velox#10600.