Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6893][VL] Fix wrong github workflows path for hashing and minor code refactor #6952

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

PHILO-HE
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the INFRA label Aug 21, 2024
Copy link

#6893

@PHILO-HE PHILO-HE changed the title [GLUTEN-6893][VL] Minor code refactor for CI workflow [GLUTEN-6893][VL] Fix wrong github workflows path for hashing and minor code refactor Aug 21, 2024
Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PHILO-HE PHILO-HE merged commit fbd066a into apache:main Aug 21, 2024
41 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_08_21_2024_time.csv log/native_master_08_20_2024_11a236dd86_time.csv difference percentage
q1 14.05 14.25 0.199 101.41%
q2 14.33 14.04 -0.292 97.96%
q3 4.31 4.56 0.250 105.80%
q4 72.54 71.77 -0.773 98.93%
q5 9.57 9.38 -0.193 97.98%
q6 2.49 3.59 1.093 143.82%
q7 6.91 4.78 -2.135 69.10%
q8 3.45 5.32 1.871 154.18%
q9 23.67 24.50 0.824 103.48%
q10 10.06 9.92 -0.131 98.70%
q11 38.49 38.51 0.020 100.05%
q12 1.36 1.38 0.016 101.15%
q13 6.57 6.51 -0.061 99.07%
q14a 45.87 46.89 1.017 102.22%
q14b 42.04 43.62 1.579 103.76%
q15 2.30 2.50 0.196 108.52%
q16 46.53 46.35 -0.174 99.63%
q17 4.98 5.00 0.021 100.42%
q18 6.82 8.62 1.792 126.26%
q19 3.54 2.11 -1.433 59.55%
q20 1.60 1.51 -0.085 94.67%
q21 1.04 1.07 0.021 101.97%
q22 7.68 7.77 0.090 101.17%
q23a 105.71 104.27 -1.438 98.64%
q23b 128.97 126.59 -2.381 98.15%
q24a 113.15 105.12 -8.032 92.90%
q24b 111.98 118.20 6.221 105.56%
q25 4.11 4.31 0.206 105.02%
q26 3.14 3.13 -0.011 99.65%
q27 6.99 4.68 -2.311 66.96%
q28 30.50 34.42 3.922 112.86%
q29 9.37 12.40 3.027 132.31%
q30 5.14 5.82 0.681 113.25%
q31 7.57 7.03 -0.535 92.93%
q32 1.47 1.20 -0.267 81.79%
q33 4.39 4.34 -0.057 98.71%
q34 4.12 3.75 -0.369 91.04%
q35 7.73 7.92 0.198 102.56%
q36 4.64 4.77 0.127 102.73%
q37 4.63 4.91 0.280 106.05%
q38 13.69 13.48 -0.209 98.48%
q39a 3.09 3.11 0.017 100.55%
q39b 2.98 2.88 -0.109 96.36%
q40 3.73 3.92 0.188 105.04%
q41 0.72 0.67 -0.045 93.78%
q42 0.96 0.96 -0.002 99.78%
q43 4.60 4.65 0.055 101.19%
q44 9.34 10.08 0.743 107.96%
q45 3.26 3.35 0.095 102.93%
q46 3.79 3.63 -0.163 95.71%
q47 18.67 18.61 -0.062 99.67%
q48 5.23 5.28 0.047 100.91%
q49 9.24 9.01 -0.232 97.49%
q50 21.69 21.62 -0.066 99.70%
q51 10.12 9.97 -0.147 98.54%
q52 1.12 1.06 -0.063 94.35%
q53 2.39 2.47 0.081 103.37%
q54 3.84 3.88 0.038 101.00%
q55 1.20 1.42 0.216 117.98%
q56 4.16 4.35 0.196 104.72%
q57 10.92 11.39 0.467 104.27%
q58 3.12 2.45 -0.669 78.56%
q59 11.01 11.01 -0.010 99.91%
q60 4.05 4.11 0.066 101.63%
q61 3.99 4.15 0.161 104.03%
q62 4.54 4.59 0.051 101.13%
q63 2.32 2.45 0.135 105.83%
q64 59.69 60.37 0.682 101.14%
q65 17.20 18.96 1.759 110.22%
q66 3.93 4.13 0.203 105.17%
q67 390.83 381.80 -9.032 97.69%
q68 3.74 3.65 -0.087 97.68%
q69 5.42 5.47 0.053 100.97%
q70 13.04 11.77 -1.272 90.25%
q71 2.38 2.54 0.160 106.72%
q72 214.73 215.14 0.414 100.19%
q73 2.20 2.36 0.166 107.55%
q74 23.22 23.43 0.210 100.90%
q75 27.08 27.04 -0.035 99.87%
q76 12.48 11.08 -1.399 88.79%
q77 2.26 2.19 -0.079 96.51%
q78 50.04 52.27 2.228 104.45%
q79 3.95 3.79 -0.155 96.09%
q80 12.38 12.45 0.074 100.60%
q81 4.84 4.86 0.017 100.36%
q82 7.13 7.45 0.321 104.50%
q83 1.71 1.64 -0.063 96.33%
q84 2.75 2.91 0.159 105.78%
q85 7.16 7.50 0.344 104.80%
q86 3.98 4.16 0.172 104.32%
q87 13.39 13.78 0.385 102.87%
q88 21.39 21.90 0.512 102.40%
q89 3.56 3.78 0.223 106.26%
q90 3.33 3.50 0.172 105.17%
q91 2.01 2.41 0.396 119.66%
q92 1.34 1.26 -0.080 94.07%
q93 41.13 39.13 -2.000 95.14%
q94 25.33 25.60 0.264 101.04%
q9 88.76 90.71 1.947 102.19%
q5 2.74 2.73 -0.006 99.77%
q96 17.46 17.33 -0.122 99.30%
q97 2.02 1.94 -0.079 96.12%
q98 10.21 10.59 0.376 103.68%
q99 10.21 10.59 0.376 103.68%
total 2192.41 2192.99 0.580 100.03%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_08_21_2024_time.csv log/native_master_08_20_2024_11a236dd86_time.csv difference percentage
q1 40.11 40.11 -0.003 99.99%
q2 29.85 30.06 0.208 100.70%
q3 53.61 51.48 -2.128 96.03%
q4 41.68 42.79 1.113 102.67%
q5 107.77 104.90 -2.870 97.34%
q6 13.03 13.17 0.140 101.08%
q7 116.21 116.23 0.024 100.02%
q8 116.50 114.60 -1.899 98.37%
q9 169.24 170.51 1.275 100.75%
q10 65.91 66.72 0.817 101.24%
q11 27.11 27.42 0.307 101.13%
q12 30.53 29.40 -1.130 96.30%
q13 52.12 51.67 -0.454 99.13%
q14 27.39 25.66 -1.732 93.68%
q15 54.11 55.42 1.308 102.42%
q16 19.44 18.68 -0.763 96.07%
q17 129.61 129.49 -0.123 99.91%
q18 198.26 196.79 -1.469 99.26%
q19 26.31 26.43 0.127 100.48%
q20 42.09 43.34 1.254 102.98%
q21 386.50 375.24 -11.269 97.08%
q22 17.58 15.35 -2.240 87.26%
total 1764.95 1745.45 -19.508 98.89%

sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants