Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6950][CORE] Move specific rules into backend modules #6953

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Aug 21, 2024

Fixes #6950.

From core module,

Move below rules to Velox backend:

  • PlanOneRowRelation
  • FallbackEmptySchemaRelation

Move below rules to CH backend:

  • CommonSubexpressionEliminateRule
  • CountDistinctWithoutExpand
  • MergeTwoPhasesHashBaseAggregate
  • RewriteDateTimestampComparisonRule
  • RewriteToDateExpresstionRule

And with some extra code cleanups.

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Aug 21, 2024
Copy link

#6950

Copy link

Run Gluten Clickhouse CI

2 similar comments
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit e0602e9 into apache:main Aug 21, 2024
40 of 43 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Move specific rules into backend modules
2 participants