[GLUTEN-6997][VL] Ignore a test: cleanup file if job failed #6965
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
| withTable("t") { | ||
| spark.sql("CREATE TABLE t (c1 int, c2 string) USING PARQUET") | ||
| val table = spark.sessionState.catalog.getTableMetadata(TableIdentifier("t")) | ||
| withTable("t1") { |
There was a problem hiding this comment.
Does the change fix the issue?
If yes it's weird as:
- More
withTable('t')s are in the file withTable('t') {}should remove the files after scope exits
There was a problem hiding this comment.
@zhztheplayer, this is not the final fix. I suspect it's this test that causes following test failure, assuming its table is not removed somehow. But seems it's not.
There was a problem hiding this comment.
Aha I missed that the PR is in draft. Please go ahead. Thanks.
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
This described occasional failure is caused by a prior test "Cleanup staging files if job is failed" that doesn't remove table sometimes when exiting. The deeper reason is unknown. This patch is just a workaround fix. |
|
Run Gluten Clickhouse CI |
|
@PHILO-HE thank you for the fix, though I did not know why it would fail sometime.. |
|
But CI is still failing :( |
|
Run Gluten Clickhouse CI |
PHILO-HE
changed the title
PHILO-HE
changed the title
|
@zhztheplayer, let's temporarily ignore this test to avoid blocking PRs. Could you approve it if it's ok to you? |
|
Works for me. Thank you. |
What changes were proposed in this pull request?
There are 5 tests failed occasionally, all in GlutenInsertSuite.scala.