[GLUTEN-7023][CH] Shade dependency jars #7027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
@loudongfeng hold on let's review it |
|
It seems that some Google libraries have been shaded into the Gluten jar. Does this mean we no longer need to copy the google protobuf jar to Spark? If so, please help modify the ep/build-clickhouse/src/package.sh to remove downloading protobuf jar.
|
|
Run Gluten Clickhouse CI |
Fixed. Also updated the document file. |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
loudongfeng
force-pushed
the
shade_deps
branch
from
6711e11 to
3aff66b
Compare
|
Run Gluten Clickhouse CI |
|
LGTM |
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
* [GLUTEN-7023][CH] Shade dependency jars * [GLUTEN-7023][CH] Shade dependency jars(update pacakge script and getstart doc)
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
* [GLUTEN-7023][CH] Shade dependency jars * [GLUTEN-7023][CH] Shade dependency jars(update pacakge script and getstart doc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shade clickhouse backend dependency jars
Fixes: #7023
How was this patch tested?
Manual verification by running basic queries.