[VL] Set Spark memory overhead automatically according to off-heap size when it's not explicitly configured #7045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
FelixYBW
approved these changes
Aug 28, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…ze when it's not explicitly configured (apache#7045)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vanilla Spark, the option
spark.executor.memoryOverheadis by default calculated bymax(0.1 * on-heap size, 384m). The patch makes itmax(0.1 * off-heap size, 384m)to gain better compatibility with Velox's memory management system.If user does configure the memory overhead options, Velox backend will raise a warning when it's smaller than the recommended size during initialization.