Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix a variable name typo #7053

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

ychris78
Copy link
Contributor

What changes were proposed in this pull request?

Fix ambiguous variable name

How was this patch tested?

manual tests

@github-actions github-actions bot added the CORE works for Gluten Core label Aug 28, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [CORE] Fix ambiguous variable name [CORE] Fix a variable name typo Aug 28, 2024
@PHILO-HE
Copy link
Contributor

Thanks for your fix!

@PHILO-HE PHILO-HE merged commit 3928dc2 into apache:main Aug 28, 2024
43 of 44 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_08_28_2024_time.csv log/native_master_08_28_2024_58907cfc5e_time.csv difference percentage
q1 14.02 13.95 -0.070 99.50%
q2 13.32 12.54 -0.788 94.09%
q3 3.86 4.44 0.579 114.99%
q4 72.05 71.23 -0.819 98.86%
q5 9.26 7.56 -1.696 81.69%
q6 2.36 4.16 1.807 176.69%
q7 6.72 7.17 0.448 106.67%
q8 5.08 3.48 -1.606 68.39%
q9 24.18 26.24 2.060 108.52%
q10 9.64 10.18 0.539 105.59%
q11 39.48 38.65 -0.832 97.89%
q12 1.40 1.50 0.106 107.61%
q13 6.61 6.74 0.124 101.87%
q14a 46.08 46.11 0.038 100.08%
q14b 42.22 44.02 1.797 104.26%
q15 2.78 2.68 -0.109 96.10%
q16 46.08 45.81 -0.264 99.43%
q17 5.39 4.98 -0.405 92.49%
q18 6.91 6.87 -0.034 99.51%
q19 2.11 2.06 -0.058 97.27%
q20 1.51 2.37 0.857 156.67%
q21 1.10 1.59 0.492 144.81%
q22 7.71 7.66 -0.041 99.47%
q23a 103.66 103.22 -0.436 99.58%
q23b 128.88 127.17 -1.713 98.67%
q24a 109.30 110.61 1.303 101.19%
q24b 107.88 117.06 9.185 108.51%
q25 4.23 4.22 -0.005 99.89%
q26 3.24 3.24 -0.003 99.91%
q27 4.02 4.20 0.186 104.64%
q28 33.79 33.62 -0.171 99.49%
q29 11.05 11.12 0.066 100.60%
q30 4.94 5.93 0.988 120.00%
q31 7.50 7.24 -0.263 96.49%
q32 1.45 1.15 -0.300 79.37%
q33 4.51 4.16 -0.349 92.27%
q34 4.11 3.74 -0.365 91.12%
q35 8.32 7.91 -0.406 95.12%
q36 4.74 4.75 0.018 100.37%
q37 5.87 4.54 -1.329 77.37%
q38 14.50 13.80 -0.699 95.18%
q39a 3.27 3.64 0.370 111.31%
q39b 2.83 3.18 0.346 112.21%
q40 3.95 3.89 -0.055 98.62%
q41 0.70 0.65 -0.055 92.15%
q42 0.97 0.93 -0.034 96.48%
q43 4.83 4.82 -0.011 99.78%
q44 9.98 9.90 -0.079 99.21%
q45 3.28 3.36 0.085 102.59%
q46 3.74 3.83 0.087 102.33%
q47 19.36 18.72 -0.638 96.70%
q48 5.37 5.36 -0.009 99.84%
q49 9.27 8.71 -0.559 93.97%
q50 21.79 21.70 -0.094 99.57%
q51 9.73 10.08 0.353 103.63%
q52 1.06 1.14 0.085 108.01%
q53 2.44 2.42 -0.015 99.40%
q54 3.98 4.30 0.319 108.02%
q55 1.10 1.09 -0.011 98.98%
q56 4.15 4.15 -0.007 99.84%
q57 10.86 10.68 -0.186 98.28%
q58 2.39 2.40 0.009 100.39%
q59 11.44 11.03 -0.416 96.37%
q60 4.10 4.20 0.099 102.42%
q61 4.12 4.05 -0.069 98.32%
q62 4.59 4.63 0.037 100.81%
q63 2.35 2.28 -0.064 97.27%
q64 62.31 62.45 0.146 100.23%
q65 17.60 17.13 -0.464 97.36%
q66 5.74 3.94 -1.791 68.77%
q67 385.75 387.25 1.504 100.39%
q68 3.55 3.76 0.207 105.82%
q69 5.32 5.37 0.055 101.04%
q70 11.37 12.39 1.018 108.95%
q71 2.30 2.55 0.256 111.17%
q72 212.84 217.13 4.286 102.01%
q73 2.31 2.21 -0.101 95.61%
q74 24.25 23.52 -0.727 97.00%
q75 26.53 26.63 0.099 100.37%
q76 11.79 11.56 -0.234 98.01%
q77 2.32 2.41 0.093 104.03%
q78 49.67 49.47 -0.199 99.60%
q79 3.94 4.15 0.216 105.48%
q80 12.33 12.37 0.042 100.34%
q81 4.98 5.18 0.201 104.04%
q82 7.79 7.12 -0.668 91.42%
q83 1.74 1.72 -0.014 99.17%
q84 2.82 2.57 -0.254 90.99%
q85 8.36 8.43 0.072 100.86%
q86 4.09 4.04 -0.048 98.83%
q87 14.21 15.33 1.125 107.92%
q88 21.80 21.40 -0.401 98.16%
q89 3.51 3.91 0.399 111.35%
q90 3.58 3.28 -0.293 91.81%
q91 2.43 2.37 -0.066 97.30%
q92 1.31 1.29 -0.011 99.18%
q93 39.93 38.96 -0.967 97.58%
q94 24.47 24.42 -0.055 99.77%
q9 85.89 89.52 3.627 104.22%
q5 2.65 3.19 0.538 120.30%
q96 17.68 17.51 -0.174 99.02%
q97 2.01 1.95 -0.068 96.62%
q98 10.52 10.61 0.091 100.86%
q99 10.52 10.61 0.091 100.86%
total 2183.21 2197.98 14.761 100.68%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_08_28_2024_time.csv log/native_master_08_28_2024_da59376820_time.csv difference percentage
q1 40.45 40.10 -0.351 99.13%
q2 30.31 30.34 0.030 100.10%
q3 53.48 52.02 -1.461 97.27%
q4 41.72 40.89 -0.831 98.01%
q5 102.35 103.89 1.544 101.51%
q6 12.91 13.28 0.369 102.86%
q7 116.14 116.54 0.407 100.35%
q8 117.06 115.70 -1.359 98.84%
q9 168.17 169.83 1.656 100.98%
q10 63.46 67.03 3.574 105.63%
q11 26.85 27.13 0.281 101.05%
q12 30.31 30.03 -0.286 99.06%
q13 52.28 51.89 -0.398 99.24%
q14 25.88 26.74 0.865 103.34%
q15 56.08 53.59 -2.498 95.55%
q16 18.31 19.99 1.681 109.18%
q17 133.77 130.36 -3.418 97.44%
q18 199.77 197.94 -1.829 99.08%
q19 24.78 27.96 3.184 112.85%
q20 42.75 42.29 -0.457 98.93%
q21 390.58 380.46 -10.123 97.41%
q22 15.25 15.92 0.672 104.40%
total 1762.66 1753.91 -8.748 99.50%

sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants