Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7055][VL] Make ssh keys of gluten-vcpkg-builder configurable #7056

Closed
wants to merge 1 commit into from

Conversation

wForget
Copy link
Member

@wForget wForget commented Aug 28, 2024

What changes were proposed in this pull request?

Make ssh keys of gluten-vcpkg-builder configurable

Fixes: #7055

How was this patch tested?

After this, we can configure ssh keys for gluten-vcpkg-builder:

docker build --file docker/Dockerfile \
    --build-arg BUILDER_UID=`id -u` \
    --build-arg BUILDER_GID=`id -g` \
    --build-arg SSH_PRV_KEY="$(cat ~/.ssh/id_rsa)" \
    --build-arg SSH_PUB_KEY="$(cat ~/.ssh/id_rsa.pub)" \
    --tag "apache/gluten:gluten-vcpkg-builder_2024_08_28" \
    .

@github-actions github-actions bot added the BUILD label Aug 28, 2024
Copy link

#7055

@PHILO-HE
Copy link
Contributor

@wForget, thanks for your effort!
As the purpose is for making git clone workable in docker, can we simply use repo's https url? Assume write permission is not needed.

@wForget
Copy link
Member Author

wForget commented Aug 30, 2024

As the purpose is for making git clone workable in docker, can we simply use repo's https url? Assume write permission is not needed.

When using internal gitlab repo https url, we also need to enter the username and password. In addition, since the ssh key is bound to the gitlab user in our internal repository, we can also grant read-only permissions to the repo.
By the way, we use the gluten-vcpkg-builder image to integrate with Jenkins and use it on the Jenkins build machine to automatically build gluten.

I'm not sure if this is a common usage, if not, please ignore this change, thank you.

@PHILO-HE
Copy link
Contributor

As the purpose is for making git clone workable in docker, can we simply use repo's https url? Assume write permission is not needed.

When using internal gitlab repo https url, we also need to enter the username and password. In addition, since the ssh key is bound to the gitlab user in our internal repository, we can also grant read-only permissions to the repo. By the way, we use the gluten-vcpkg-builder image to integrate with Jenkins and use it on the Jenkins build machine to automatically build gluten.

I'm not sure if this is a common usage, if not, please ignore this change, thank you.

@wForget, thanks for your clarification! Sounds not a common usage to me, but not quite sure. Let's see whether there are any other feedback from the community. Thanks!

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale stale label Oct 15, 2024
@wForget wForget closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL][VCPKG] Support configure ssh keys for gluten vcpkg builder image
2 participants