Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7031][CORE] Initialize new module structure gluten-core / gluten-substrait #7057

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Aug 28, 2024

#7031

Part of the dependency graph after the change will become

gluten-core
  \- gluten-substrait
        |- backends-clickhouse
        \- gluten-data
             \- backends-velox

This belongs to the objective supporting mixed backend execution in Gluten.

The PR only initializes the new module structure. Will move more code in subsequent PRs.

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title DEBUG [CORE] Initialize new module structure gluten-core / gluten-substrait Aug 29, 2024
@zhztheplayer zhztheplayer changed the title [CORE] Initialize new module structure gluten-core / gluten-substrait [GLUTEN-7031][CORE] Initialize new module structure gluten-core / gluten-substrait Aug 29, 2024
@zhztheplayer zhztheplayer reopened this Aug 29, 2024
Copy link

#7031

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review August 29, 2024 01:02
Copy link

Run Gluten Clickhouse CI

@zhztheplayer
Copy link
Member Author

cc @zzcclp @baibaichen

This removes blockers towards multi-backend support of Gluten

Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

@zhztheplayer, I would prefer the follow directory structure

gluten-core
  \- gluten-substrait
        |- backends-clickhouse
        \- backends-velox
             \- velox-data 

@lwz9103
Copy link
Contributor

lwz9103 commented Aug 29, 2024

@zhztheplayer
Gluten ClickHouse CI is failed due to
cpp-ch/local-engine/proto/substrait is linked to ../../../gluten-core/src/main/resources/substrait/proto/substrait
related pr :6c92151

Can you help me to fix it.

Copy link

Run Gluten Clickhouse CI

@zhztheplayer
Copy link
Member Author

hi @baibaichen, the final goal is to implement this dep graph

gluten-core
  |- gluten-substrait
  |      \- backends-clickhouse
  \- gluten-arrow

Then backends-velox could inherit from both gluten-substrait and gluten-arrow. gluten-data may be factored out to gluten-arrow which will no longer rely on gluten-substrait.

@lwz9103
Copy link
Contributor

lwz9103 commented Aug 29, 2024

@zhztheplayer
The good news is that the gluten ch native code has compiled successfully after modifications. However, the Java code is currently failing to compile due to changes in SoftAffinity. When initializing SoftAffinity in MixedAffinitySuite, several modified parameters should be added. Can you help me resolve this issue?

image
image

You can also use the following command locally to test whether the Java code for Gluten CH can compile successfully.
mvn clean install -DskipTests -Pbackends-clickhouse -Pspark-3.3 -Pspark-ut

@zhztheplayer
Copy link
Member Author

@lwz9103 Thank you for keeping following. Let me update the PR.

Copy link

Run Gluten Clickhouse CI

@baibaichen
Copy link
Contributor

baibaichen commented Aug 29, 2024

hi @baibaichen, the final goal is to implement this dep graph

gluten-core
  |- gluten-substrait
  |      \- backends-clickhouse
  \- gluten-arrow

Then backends-velox could inherit from both gluten-substrait and gluten-arrow. gluten-data may be factored out to gluten-arrow which will no longer rely on gluten-substrait.

Which module depends on gluten-arrow? Does it only used in backends-velox?

oh, I see the idea. Is there any more new backends which depends on gluten-arrow?

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit 3af5bac into apache:main Aug 29, 2024
45 checks passed
pfzhan pushed a commit to Kyligence/kylin that referenced this pull request Sep 3, 2024
* KE-43825 Auto Update Gluten Ext Version (240829)

* Fix Build due to  apache/incubator-gluten#7057

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
pfzhan pushed a commit to Kyligence/kylin that referenced this pull request Dec 10, 2024
* KE-43825 Auto Update Gluten Ext Version (240829)

* Fix Build due to  apache/incubator-gluten#7057

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
gleonSun pushed a commit to gleonSun/kylin that referenced this pull request Dec 10, 2024
* Fix Build due to  apache/incubator-gluten#7057

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
gleonSun pushed a commit to gleonSun/kylin that referenced this pull request Dec 13, 2024
* Fix Build due to  apache/incubator-gluten#7057

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
gleonSun added a commit to gleonSun/kylin that referenced this pull request Dec 15, 2024
* Fix Build due to  apache/incubator-gluten#7057

* minor fix ut

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Co-authored-by: Guoliang Sun <[email protected]>
pfzhan pushed a commit to apache/kylin that referenced this pull request Dec 16, 2024
* Fix Build due to  apache/incubator-gluten#7057

* minor fix ut

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Co-authored-by: Guoliang Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants