Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7054][CH] Fix cse alias issues #7084

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Conversation

taiyang-li
Copy link
Contributor

@taiyang-li taiyang-li commented Sep 2, 2024

What changes were proposed in this pull request?

(Fixes: ##7054)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

github-actions bot commented Sep 2, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Sep 2, 2024

Run Gluten Clickhouse CI

@taiyang-li taiyang-li marked this pull request as ready for review September 3, 2024 02:57
Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

@taiyang-li taiyang-li changed the title [CH][WIP] Fix cse alias issues [GLUTEN-7054][CH] Fix cse alias issues Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

#7054

@lgbo-ustc
Copy link
Contributor

LGTM

Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit 6e0b119 into apache:main Sep 3, 2024
6 checks passed
@taiyang-li taiyang-li deleted the fix_cse_alias_bug branch September 3, 2024 09:46
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
* fix cse alias issues

* fix issue apache#7054

* fix uts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants