-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-6813][CH] Support soundex function #7093
Conversation
Run Gluten Clickhouse CI |
207e485
to
34b4a39
Compare
Run Gluten Clickhouse CI |
...en-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala
Outdated
Show resolved
Hide resolved
@exmy where is the ut to test this funtion? |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* support soundex function * add uts * fix style * fix failed uts
* support soundex function * add uts * fix style * fix failed uts
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #6813)
How was this patch tested?
Original spark test "soundex function" in GlutenStringFunctionsSuite