[GLUTEN-7096] [CH] fix exception when same names in group by #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
3 similar comments
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
please fix conflicts first |
|
Run Gluten Clickhouse CI |
zzcclp
approved these changes
Sep 24, 2024
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Sep 26, 2024
…pache#7101)" This reverts commit c8cfe11.
baibaichen
added a commit
that referenced
this pull request
Sep 26, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…7101) * [GLUTEN-7096] [CH] fix exception when same names in group by * move case to hive * fix test failure * fix test failure
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
* Revert "[GLUTEN-7096] [CH] fix exception when same names in group by (apache#7101)" This reverts commit c8cfe11. * Add UT for 'GLUTEN-7367: Memory limit exceeded' * fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr fix two problems, one is that when group by has same names, the duplicated names will be remove by distinct in genHashAggregateExecTransformer, and cause Missmatch result columns size exception. The other is that when group by has same names but with different qualifier due to alias table name, the same names are passed to clickhouse, and cause Mismatch output schema exception.
The solution is that we distinct the groupings in Agg by ignoring qualifier, and insert a Project if has same names.
(Fixes: #7096)
How was this patch tested?
This patch was tested by unit tests.