Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7100][CH] support function timestamp_seconds/timestamp_millis/timestamp_micros #7102

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

taiyang-li
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #7100)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

#7100

Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

@taiyang-li taiyang-li marked this pull request as draft September 3, 2024 12:44
Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

@taiyang-li taiyang-li marked this pull request as ready for review September 3, 2024 13:44
Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Sep 4, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 4, 2024

Run Gluten Clickhouse CI

@taiyang-li taiyang-li requested a review from exmy September 4, 2024 02:33
exmy
exmy previously approved these changes Sep 4, 2024
Copy link

github-actions bot commented Sep 5, 2024

Run Gluten Clickhouse CI

@taiyang-li
Copy link
Contributor Author

2 uts are excluded because of #7169

  • store and retrieve column stats in different time zones
  • GLUTEN - store and retrieve column stats in different time zones

Copy link

github-actions bot commented Sep 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 9, 2024

Run Gluten Clickhouse CI

baibaichen
baibaichen previously approved these changes Sep 10, 2024
Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@taiyang-li taiyang-li merged commit cf010dd into apache:main Sep 11, 2024
46 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
…/timestamp_micros (apache#7102)

* support function timestamp_xxx

* fix style

* disable ut TIMESTAMP_SECONDS because of ClickHouse/ClickHouse#69280

* fix all failed uts

* fix failed uts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] support function timestamp_seconds/timestamp_micros/timestamp_millis
3 participants