Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Remove a limit for BHJ in stage fallback policy #7105

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Sep 3, 2024

What changes were proposed in this pull request?

Currently, Gluten allows that BroadcastExchange is offloaded, but BHJ falls back. So we can remove the limit.

How was this patch tested?

An added test.

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Sep 3, 2024

Run Gluten Clickhouse CI

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Sep 3, 2024

@weiting-chen

Copy link
Contributor

@weiting-chen weiting-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@PHILO-HE PHILO-HE merged commit 44634ad into apache:main Sep 4, 2024
43 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants