[GLUTEN-5880][CORE] Ignore fallback for ColumnarWriteFilesExec children #7113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wForget
changed the title
|
Run Gluten Clickhouse CI |
wForget
changed the title
|
@Yohahaha @zhztheplayer could you please take a look? |
Yohahaha
reviewed
Sep 4, 2024
| checkWriteFilesAndGetChild(df2) | ||
| val fallbackSummary = GlutenImplicits | ||
| .collectQueryExecutionFallbackSummary(spark, df2.queryExecution) | ||
| assert(fallbackSummary.numFallbackNodes == 0) |
There was a problem hiding this comment.
would you port the test to Spark34 module?
|
Run Gluten Clickhouse CI |
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As title
Fixes: #5880
How was this patch tested?
added unit test and manual test:
before:
after this:
