[GLUTEN-7118][VL] Fix duckdb target issue when vcpkg is enabled #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
changed the title
|
@zhouyuan, please verify whether it can fix the issue you encountered. |
PHILO-HE
changed the title
Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
approved these changes
Sep 5, 2024
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Nov 18, 2024
weiting-chen
added a commit
that referenced
this pull request
Nov 20, 2024
* [MINOR] Remove duplicate mvn packages (#6560) * [VL] Improve package scripts (#6569) * [GLUTEN-6569][VL] Delete unnecessary gcc9 enabling from package script (#6730) * [GLUTEN-7118][VL] Fix duckdb target issue when vcpkg is enabled (#7117) --------- Co-authored-by: Zhen Wang <[email protected]> Co-authored-by: PHILO-HE <[email protected]>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #7118.
duckdb target is required when
build_tests=ON.We need to use
vcpkg_cmake_config_fixupfor duckdb to corrects issues like absolute paths and incorrectly placed binaries.How was this patch tested?
Local test with docker.