Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-4039][VL] Support array insert function for spark 3.4+ #7123

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ivoson
Copy link
Contributor

@ivoson ivoson commented Sep 5, 2024

What changes were proposed in this pull request?

Add support of array_insert function for velox backend.

Velox side changes: facebookincubator/velox#9851

How was this patch tested?

New UT added.

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

#4039

Copy link

github-actions bot commented Sep 5, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 5, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Sep 5, 2024

Run Gluten Clickhouse CI

@ivoson ivoson marked this pull request as ready for review September 5, 2024 10:03
@ivoson
Copy link
Contributor Author

ivoson commented Sep 6, 2024

cc @PHILO-HE can you please review this PR? Thanks.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE changed the title [GLUTEN-4039][VL] Add array insert function for spark 3.4+ [GLUTEN-4039][VL] Support array insert function for spark 3.4+ Sep 6, 2024
@PHILO-HE PHILO-HE merged commit 37d09c1 into apache:main Sep 6, 2024
44 checks passed
@ivoson ivoson deleted the array_insert_new branch September 6, 2024 05:59
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants