Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7130][CORE] Skip command execution when collect qe fallback summary #7132

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

wForget
Copy link
Member

@wForget wForget commented Sep 5, 2024

What changes were proposed in this pull request?

Skip command execution when collect qe fallback summary

Fixes: #7130

How was this patch tested?

@github-actions github-actions bot added the CORE works for Gluten Core label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

#7130

Copy link

github-actions bot commented Sep 5, 2024

Run Gluten Clickhouse CI

@wForget
Copy link
Member Author

wForget commented Sep 5, 2024

cc @ulysses-you

Copy link
Contributor

@ulysses-you ulysses-you left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ulysses-you ulysses-you merged commit f3b2ba4 into apache:main Sep 5, 2024
43 checks passed
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
weiting-chen pushed a commit to weiting-chen/gluten that referenced this pull request Nov 18, 2024
weiting-chen added a commit that referenced this pull request Nov 20, 2024
* [GLUTEN-7024][VL] Skip call collectMetrics when the task does not call next() (#7025)

* [GLUTEN-7130][CORE] Skip command execution when collect qe fallback summary (#7132)

* [VL] Add config for show velox task metrics when finished (#6573)

---------

Co-authored-by: zhaokuo <[email protected]>
Co-authored-by: Zhen Wang <[email protected]>
Co-authored-by: Yang Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] GlutenImplicits#collectQueryExecutionFallbackSummary may cause command to execute eagerly
2 participants