Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix weekly build job failure #7163

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Sep 9, 2024

Fix the below error on ubuntu-20.04.

gluten::VeloxHashShuffleWriterMemoryTest_kStop_Test::TestBody()':
2024-09-09T04:14:59.2589597Z /__w/incubator-gluten/incubator-gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc:610:5: error: 'ASSERT' was not declared in this scope; did you mean 'ASSERT_EQ'?
2024-09-09T04:14:59.2591325Z   610 |     ASSERT(reclaimed >= 2000);
2024-09-09T04:14:59.2591918Z       |     ^~~~~~
2024-09-09T04:14:59.2592344Z       |     ASSERT_EQ
2024-09-09T04:14:59.2594088Z /__w/incubator-gluten/incubator-gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc:593:19: warning: unused variable 'partitioning' [-Wunused-variable]
2024-09-09T04:14:59.2596113Z   593 |   for (const auto partitioning : {Partitioning::kSingle, Partitioning::kRoundRobin}) {
2024-09-09T04:14:59.2597049Z       |                   ^~~~~~~~~~~~
2024-09-09T04:14:59.2599294Z /__w/incubator-gluten/incubator-gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc: In member function 'virtual void gluten::VeloxHashShuffleWriterMemoryTest_kStopComplex_Test::TestBody()':
2024-09-09T04:14:59.2602574Z /__w/incubator-gluten/incubator-gluten/cpp/velox/tests/VeloxShuffleWriterTest.cc:633:3: error: 'ASSERT' was not declared in this scope; did you mean 'ASSERT_EQ'?
2024-09-09T04:14:59.2604745Z   633 |   ASSERT(reclaimed >= 2000);
2024-09-09T04:14:59.2605310Z       |   ^~~~~~
2024-09-09T04:14:59.2605714Z       |   ASSERT_EQ

Copy link

github-actions bot commented Sep 9, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

This reverts commit 064bf66.
@github-actions github-actions bot removed the INFRA label Sep 9, 2024
@PHILO-HE PHILO-HE merged commit 856504b into apache:main Sep 9, 2024
10 checks passed
dcoliversun pushed a commit to dcoliversun/gluten that referenced this pull request Sep 11, 2024
@PHILO-HE PHILO-HE deleted the fix-weekly-build branch November 4, 2024 07:46
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants