[VL] Make conf option s.g.s.c.shuffledHashJoin.optimizeBuildSide work correctly with option s.g.s.c.forceShuffledHashJoin
#7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith s.g.s.c.forceShuffledHashJoin
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
rui-mo
approved these changes
Sep 11, 2024
Thanks although I found it's an easy way to represent a config option in title. Or if you have better suggestions? Like |
zhztheplayer
changed the title
s.g.s.c.shuffledHashJoin.optimizeBuildSide work correctly with option s.g.s.c.forceShuffledHashJoin
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
…rk correctly with option `s.g.s.c.forceShuffledHashJoin` (apache#7186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
s.g.s.c.shuffledHashJoin.optimizeBuildSide==falseands.g.s.c.forceShuffledHashJoin=true, SMJ will be converted to SHJ with a randomly chosen build side. This PR fixes the issue by choosing a smaller one inRewriteJoinrule.