Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][BUILD] Extract gcc version from libgluten.so #7189

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

wecharyu
Copy link
Contributor

What changes were proposed in this pull request?

Read the gcc version from generated libgluten.so file instead of use gcc --version directly.

We may compile cpp codes and scala codes in different bash, if multiple versions of GCC are installed on the system and the GCC version used by C++ is not correctly sourced during Scala code compilation, the generated GCC version by gcc --version may be inaccurate in gluten-build-info.properties.

(Fixes: #ISSUE-ID)

How was this patch tested?

Manually test on local by comparing the generated gluten-build-info.properties files.

@github-actions github-actions bot added the BUILD label Sep 10, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor

@wecharyu, please rebase the code to fix CI failure. BTW, seems this is not workable for macOS. @xumingming, do you have any comment?

@wecharyu
Copy link
Contributor Author

@PHILO-HE how about using strings command? It should be available in both linux and macOS.

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Sep 11, 2024

@PHILO-HE how about using strings command? It should be available in both linux and macOS.

@wecharyu, I guess it is more appropriate.

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! cc @xumingming

@PHILO-HE PHILO-HE merged commit 9997927 into apache:main Sep 11, 2024
42 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants