[GLUTEN-7145][CH][PART]refactor for rel parsers #7193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
c7db902 to
8262c67
Compare
|
Run Gluten Clickhouse CI |
liuneng1994
reviewed
Sep 11, 2024
| return query_plan; | ||
| } | ||
|
|
||
| // This is sourde noce, there is no input |
There was a problem hiding this comment.
typo: sourde noce -> source node
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
8262c67 to
1072a7e
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
1072a7e to
fdf01f9
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
fdf01f9 to
8fb194e
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
8da6707 to
e058a4f
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
e058a4f to
e4458cc
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
e4458cc to
735634a
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
735634a to
01184c3
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
new_rel_parser
branch
from
01184c3 to
d9a098e
Compare
|
Run Gluten Clickhouse CI |
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Sep 13, 2024
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Sep 13, 2024
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Sep 18, 2024
Fix UT build due to apache#7193
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Sep 18, 2024
Fix UT build due to apache#7193
baibaichen
added a commit
that referenced
this pull request
Sep 18, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240918) * Fix build due to ENABLE_ROCKSDB=OFF caused by #7239 * Fix UT build due to #6723 * Fix UT build due to #7193 * Fix Build due to ClickHouse/ClickHouse#69298 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Sep 19, 2024
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Sep 19, 2024
(cherry picked from commit 53c5cf1)
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
What changes were proposed in this pull request? (Please fill in changes proposed in this fix) Fixes: apache#7145 Refactor SerializedPlanParser::parseOp. RelParser don't need to call SerializedPlanParser from down to top at the parsing process How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) unit tests (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
) * [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240918) * Fix build due to ENABLE_ROCKSDB=OFF caused by apache#7239 * Fix UT build due to apache#6723 * Fix UT build due to apache#7193 * Fix Build due to ClickHouse/ClickHouse#69298 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #7145
Refactor
SerializedPlanParser::parseOp.RelParserdon't need to callSerializedPlanParserfrom down to top at the parsing processHow was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)