Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add tests for Velox SMJ's coverage #7195

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Sep 11, 2024

Add GlutenInnerJoinSuiteForceShjOff and GlutenOuterJoinSuiteForceShjOff for testing Veox SMJ.

A couple of cases in GlutenOuterJoinSuiteForceShjOff cannot pass due to result mismatches. Added to exclusions.

The tests are added only in Spark 3.5 UTs for maintenance consideration.

@github-actions github-actions bot added the CORE works for Gluten Core label Sep 11, 2024
@apache apache deleted a comment from github-actions bot Sep 11, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

rui-mo
rui-mo previously approved these changes Sep 11, 2024
@zhztheplayer
Copy link
Member Author

cc @JkSelf

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit da52595 into apache:main Sep 12, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants