-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE][1.2] Bump branch-1.2 version to 1.2.1-SNAPSHOT #7290
[CORE][1.2] Bump branch-1.2 version to 1.2.1-SNAPSHOT #7290
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
@@ -7,7 +7,7 @@ | |||
<parent> | |||
<groupId>org.apache.gluten</groupId> | |||
<artifactId>gluten-it</artifactId> | |||
<version>1.2.0</version> | |||
<version>1.2.1-SNAPSHOT</version> | |||
</parent> | |||
|
|||
<artifactId>gluten-it-common</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiting-chen, this should also be bumped.
Run Gluten Clickhouse CI |
e489620
to
511fd4c
Compare
Run Gluten Clickhouse CI |
@weiting-chen Why was this bumped up to 1.2.1-SNAPSHOT? Don't we create a separate branch for 1.2.1 - branch-1.2.1, similar to branch-1.1.1? |
Hi @surnaik, this is following Spark's release convention. Spark uses 3.5.4-SNAPSHOT as development version on branch-3.5, see |
Thanks, it makes sense. I was of the opinion that we cut separate branches for each subminor version as well, similar to branch-1.1.1. No worries, this sounds good. In future, we'll stick to the same style as Spark I'm assuming. |
What changes were proposed in this pull request?
Bump branch-1.2 version to 1.2.1-SNAPSHOT
How was this patch tested?
local server