Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Remove unused allPushDownFilters param #7317

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Sep 23, 2024

What changes were proposed in this pull request?

After #7215, allPushDownFilters param of createBatchScanTransformer and createFileSourceScanTransformer is unused.
In addition, batchScan's runtimeFilters will not change.

How was this patch tested?

CI.

@github-actions github-actions bot added the CORE works for Gluten Core label Sep 23, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer merged commit 6bcc28b into apache:main Sep 24, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants