Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Prepare shim API for breaking change in SPARK-48610 #7445

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Oct 9, 2024

SPARK-48610 removes QueryPlan.OP_ID_TAG which is used by GlutenExplainUtils (introduced in #2247), the PR prepares shim code for the change.

As prerequisite of #7138.

@github-actions github-actions bot added the CORE works for Gluten Core label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

1 similar comment
Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

fixup

fixup

fixup
Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer marked this pull request as ready for review October 9, 2024 08:28
Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Oct 9, 2024

Run Gluten Clickhouse CI

Copy link
Contributor

@Yohahaha Yohahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhztheplayer zhztheplayer merged commit 16bc416 into apache:main Oct 10, 2024
44 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants