[GLUTEN-7458][VL] Upgrade to GCC-11 for centos-7/8 and ubuntu-20.04 #7578
Conversation
PHILO-HE
force-pushed
the
upgrade-gcc
branch
2 times, most recently
from
0afb29d to
b90724c
Compare
|
@PHILO-HE should we upgrade the docker image in a separate PR, and tag it with gcc-11? |
@zhouyuan, maybe, we can directly install upgraded GCC in this pr with the old docker images used. After docker images are updated with new gcc installed, we can remove unnecessary installation from yml. Regarding updating docker image, I think we should keep both gcc-9/11 installed. Then, use required gcc version by sourcing corresponding SCL devtoolset. This is for considering branch-1.2 GHA workflow, where gcc-9 is still used. |
Yes, that's the issue. We will need to modify the branch-1.2 also if image is updated with same name |
PHILO-HE
force-pushed
the
upgrade-gcc
branch
4 times, most recently
from
426f5fb to
fd9b430
Compare
| @@ -135,60 +134,18 @@ install_centos_8() { | |||
| install_maven_from_source | |||
| } | |||
|
|
|||
| install_ubuntu_18.04() { | |||
There was a problem hiding this comment.
We don't need this, thanks.
|
@Yohahaha, do you have any comment? |
no comments, feel free to merge this PR. |
|
The CI https://github.com/apache/incubator-gluten/actions/runs/11499412404/job/32007324721?pr=7648 for branch 1.2 seems to be failing due to this change, do we have a solution? |
What changes were proposed in this pull request?
Since the recently upgraded folly in Velox requires GCC >=10, we need to upgrade it for OSes whose default gcc package doesn't meet this requirement, such as centos-7/8 and ubuntu-20.04.
Also remove build tool setup for ubuntu-18.04 from
setup-build-depends.sh, as it is not officially supported now.How was this patch tested?
CI.