[GLUTEN-7750][VL]: store unsafe batches data #7944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
Zand100
changed the title
zhouyuan
reviewed
Nov 20, 2024
| import org.apache.spark.unsafe.memory.MemoryBlock | ||
| import org.apache.spark.util.collection.unsafe.sort.UnsafeSorterSpillWriter | ||
|
|
||
| class UnsafeArray(taskMemoryManager: TaskMemoryManager) |
There was a problem hiding this comment.
@zhztheplayer
should we use the mem pool from Gluten?
|
Can we close this one and continue on #7902? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds a binary container implementing a Spark MemoryConsumer to be used instead of Array[Array[Bytes]]. Uses that binary container with the existing object handles in
ColumnarBuildSideRelation.(Fixes: #7750)
Duplicate of #7902
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)