Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7028][CH][Part-9] Collecting Delta stats for parquet #7993

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Nov 19, 2024

What changes were proposed in this pull request?

Introducing DeltaStats to collect stats as delta does.

(Fixes: #7028)

How was this patch tested?

Using Existed Uts

In test("test parquet table write with the delta"), adding logic to verify delta stats

    if (spark35) {
      val vanillaTable = "lineitem_delta_parquet_vanilla"
      withSQLConf((GlutenConfig.NATIVE_WRITER_ENABLED.key, "false")) {
        doInsert(drop(vanillaTable), createLineitem(vanillaTable), insert(vanillaTable))
      }
      val expected = DeltaStatsUtils
        .statsDF(
          spark,
          s"$basePath/$vanillaTable/_delta_log/00000000000000000001.json",
          q1SchemaString)
        .collect()

      checkAnswer(
        DeltaStatsUtils.statsDF(
          spark,
          s"$basePath/$table/_delta_log/00000000000000000001.json",
          q1SchemaString),
        expected
      )
    }

Copy link

#7028

Copy link

Run Gluten Clickhouse CI on x86

2 similar comments
Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

Copy link

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen marked this pull request as ready for review November 21, 2024 08:37
@baibaichen baibaichen changed the title [GLUTEN-7028][CH][Part-9] Collecting Delta stats [GLUTEN-7028][CH][Part-9] Collecting Delta stats for parquet Nov 21, 2024
@baibaichen baibaichen merged commit e872cd8 into apache:main Nov 21, 2024
11 checks passed
@baibaichen baibaichen deleted the feature/delta-stats branch November 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Fully Support writing parquet and mergetree in spark 3.5.x with delta protocol
2 participants