Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8257][CORE] Make IDEA support IssueNavigationLink #8258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

merrily01
Copy link
Contributor

@merrily01 merrily01 commented Dec 17, 2024

What changes were proposed in this pull request?

Make IDEA support IssueNavigationLink.

(Fixes: #8257)

How was this patch tested?

Manual test.

Before:

image

After:

image

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@merrily01 merrily01 changed the title [Core] Make IDEA support IssueNavigationLink [GLUTEN-8257][Core] Make IDEA support IssueNavigationLink Dec 17, 2024
Copy link

#8257

@PHILO-HE
Copy link
Contributor

@merrily01, could you clarify how this window is opened? It's just for checking commit history? Seems Annotate is more useful to see historical commits for some file. And the IDE already supports jumping to the commit link.

@Yohahaha
Copy link
Contributor

@merrily01, could you clarify how this window is opened? It's just for checking commit history? Seems Annotate is more useful to see historical commits for some file. And the IDE already supports jumping to the commit link.

sadly, IDE does not support jumping to the commit link for now.

Copy link
Contributor

@Yohahaha Yohahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very helpful improvement

@Yohahaha Yohahaha changed the title [GLUTEN-8257][Core] Make IDEA support IssueNavigationLink [GLUTEN-8257][CORE] Make IDEA support IssueNavigationLink Dec 18, 2024
@zhztheplayer
Copy link
Member

zhztheplayer commented Dec 18, 2024

@merrily01

The feature looks great. Though will this change create conflict between repo's and user's vcs.xml files?

@Yohahaha
Copy link
Contributor

maybe we should use a new doc to let user integrate to their IDEA.

@merrily01
Copy link
Contributor Author

@merrily01

The feature looks great. Though will this change create conflict between repo's and user's vcs.xml files?

Yeah,if the user has a vcs.xml locally, it may update the file or cause conflicts just like other file, when pulling the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Make IDEA support IssueNavigationLink
4 participants