Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] Hotfix to #8212 #8259

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[CH] Hotfix to #8212 #8259

merged 1 commit into from
Dec 17, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Dec 17, 2024

What changes were proposed in this pull request?

#8212 introduced testGluten("function to_date") which is failed in spark32, let's ignore it

[2024-12-17T09:40:35.895Z] - Gluten - function to_date *** FAILED ***
[2024-12-17T09:40:35.895Z]   org.apache.spark.sql.catalyst.analysis.UnresolvedException: Invalid call to dataType on unresolved object
[2024-12-17T09:40:35.895Z]   at org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute.dataType(unresolved.scala:160)
[2024-12-17T09:40:35.895Z]   at org.apache.gluten.extension.RewriteToDateExpresstionRule.rewriteParseToDate(RewriteToDateExpresstionRule.scala:98)
[2024-12-17T09:40:35.895Z]   at org.apache.gluten.extension.RewriteToDateExpresstionRule.visitExpression(RewriteToDateExpresstionRule.scala:66)
[2024-12-17T09:40:35.895Z]   at org.apache.gluten.extension.RewriteToDateExpresstionRule.$anonfun$visitPlan$1(RewriteToDateExpresstionRule.scala:56)
[2024-12-17T09:40:35.895Z]   at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)
[2024-12-17T09:40:35.895Z]   at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62)
[2024-12-17T09:40:35.895Z]   at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55)
[2024-12-17T09:40:35.895Z]   at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49)
[2024-12-17T09:40:35.895Z]   at scala.collection.TraversableLike.map(TraversableLike.scala:286)
[2024-12-17T09:40:35.895Z]   at scala.collection.TraversableLike.map$(TraversableLike.scala:279)

How was this patch tested?

Existed UTs

@github-actions github-actions bot added the CORE works for Gluten Core label Dec 17, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI on x86

@zml1206 zml1206 merged commit 41aa153 into apache:main Dec 17, 2024
45 of 46 checks passed
@baibaichen baibaichen deleted the feature/hotfix_8212 branch December 17, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants