New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-8283][CH] Eliminate CSE via `ExpressionParser` #8284

Merged

lgbo-ustc merged 4 commits into apache:main from bigo-sg:cse_in_actions_dag

Dec 31, 2024

Contributor

lgbo-ustc commented Dec 19, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #8283

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

github-actions bot added the CLICKHOUSE label

github-actions bot commented Dec 19, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Other pull requests

github-actions bot commented Dec 19, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc changed the title ~~[GLUTEN-][CH] Eliminate CSE during converting substrait expression to actions dag~~ [GLUTEN-8283][CH] Eliminate CSE during converting substrait expression to actions dag

github-actions bot commented Dec 20, 2024

lgbo-ustc force-pushed the cse_in_actions_dag branch from bda2f7a to d480e5c Compare

December 26, 2024 02:49

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

1 similar comment

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 386c02c to 4068fbd Compare

December 26, 2024 04:15

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

1 similar comment

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 34125ca to 701e5b2 Compare

December 26, 2024 07:47

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 701e5b2 to 6f22805 Compare

December 26, 2024 08:03

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 6f22805 to 811368b Compare

December 26, 2024 08:06

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 811368b to da19d03 Compare

December 26, 2024 08:07

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc changed the title ~~[GLUTEN-8283][CH] Eliminate CSE during converting substrait expression to actions dag~~ [GLUTEN-8283][CH] Eliminate CSE in ExpressionParser

lgbo-ustc force-pushed the cse_in_actions_dag branch from da19d03 to 4c9f63f Compare

December 26, 2024 08:34

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Outdated Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Outdated Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Outdated Show resolved Hide resolved

taiyang-li reviewed

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Outdated Show resolved Hide resolved

lgbo-ustc force-pushed the cse_in_actions_dag branch from 4c9f63f to fe3b256 Compare

December 26, 2024 09:04

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

taiyang-li requested changes

View reviewed changes

cpp-ch/local-engine/Parser/ExpressionParser.cpp Outdated Show resolved Hide resolved

lgbo-ustc changed the title ~~[GLUTEN-8283][CH] Eliminate CSE in ExpressionParser~~ [GLUTEN-8283][CH] Eliminate CSE via ExpressionParser

lgbo-ustc force-pushed the cse_in_actions_dag branch from fe3b256 to 5c944d2 Compare

December 26, 2024 11:30

github-actions bot commented Dec 26, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 5c944d2 to 94489fa Compare

December 27, 2024 01:20

github-actions bot commented Dec 27, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 94489fa to 4f29471 Compare

December 27, 2024 03:09

github-actions bot commented Dec 27, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 4f29471 to 2ae5744 Compare

December 27, 2024 08:02

github-actions bot commented Dec 27, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc force-pushed the cse_in_actions_dag branch from 2ae5744 to eb9bcb3 Compare

December 27, 2024 08:34

github-actions bot commented Dec 27, 2024

Run Gluten Clickhouse CI on x86

baibaichen approved these changes

View reviewed changes

Contributor

baibaichen left a comment

LGTM

lgbo-ustc force-pushed the cse_in_actions_dag branch from eb9bcb3 to 46ba42e Compare

December 30, 2024 02:15

github-actions bot commented Dec 30, 2024

Run Gluten Clickhouse CI on x86

baibaichen approved these changes

View reviewed changes

Contributor

baibaichen left a comment

LGTM

lgbo-ustc force-pushed the cse_in_actions_dag branch from 46ba42e to c0bb2da Compare

December 30, 2024 06:28

github-actions bot commented Dec 30, 2024

Run Gluten Clickhouse CI on x86

taiyang-li approved these changes

View reviewed changes

lgbo-ustc added 4 commits

December 31, 2024 12:08


          eliminate cse during convert substrait expression to actions dag

0ed12d6


          not match non-deterministic function

97e256b


          dummpy column

70994f6


          update

941eecb

lgbo-ustc force-pushed the cse_in_actions_dag branch from c0bb2da to 941eecb Compare

December 31, 2024 04:09

github-actions bot commented Dec 31, 2024

Run Gluten Clickhouse CI on x86

lgbo-ustc merged commit 7503ce8 into apache:main

8 checks passed

Contributor Author

lgbo-ustc commented Dec 31, 2024

A bench test as following

before

after

baibaichen mentioned this pull request

Revert "[GLUTEN-8327][CORE] Introduce the ConfigEntry to make the config definition more flexible (#8328)" #8382

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels