Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CH] Refactor: don't using namespace DB in header #8300

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Dec 22, 2024

What changes were proposed in this pull request?

By exlcuding Storages/MergeTree/SparkStorageMergeTree.h from cpp-ch/local-engine/Parser/SerializedPlanParser.h for reduceing unnecessry dependency, I found many compiler erros since SparkStorageMergeTree.h contains using namespace DB in namespace local_engine.

Note

In some guidelines:
5. Never ever use a using namespace statement at global or namespace scope in a header file.
This is strongly discouraged, since it would pollute the global or respective namespace for every file that includes said header file.

So, I remove using namespace DB from headers

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten ClickHouse CI on ARM

Copy link

Run Gluten ClickHouse CI on ARM

@baibaichen baibaichen merged commit b0e9a04 into apache:main Dec 23, 2024
10 checks passed
@baibaichen baibaichen deleted the refactor_include branch December 23, 2024 07:33
Copy link
Contributor

@taiyang-li taiyang-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants