[CH] Refactor: don't using namespace DB
in header
#8300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
By exlcuding
Storages/MergeTree/SparkStorageMergeTree.h
from cpp-ch/local-engine/Parser/SerializedPlanParser.h for reduceing unnecessry dependency, I found many compiler erros sinceSparkStorageMergeTree.h
containsusing namespace DB
innamespace local_engine
.Note
In some guidelines:
5. Never ever use a using namespace statement at global or namespace scope in a header file.
This is strongly discouraged, since it would pollute the global or respective namespace for every file that includes said header file.
So, I remove
using namespace DB
from headersHow was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)