Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-8313][VL] Enable json_array_length #8314

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −4
Draft

[GLUTEN-8313][VL] Enable json_array_length #8314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e22b9
Enable json_array_length
WangGuangxin Dec 24, 2024
f54a5fa
change velox branch to test ci
WangGuangxin Dec 24, 2024
68083c5
test ci
WangGuangxin Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ abstract class ScalarFunctionsValidateSuite extends FunctionsValidateSuite {
}
}

ignore("json_array_length") {
test("json_array_length") {
runQueryAndCompare(
s"select *, json_array_length(string_field1) " +
s"from datatab limit 5")(checkGlutenOperatorMatch[ProjectExecTransformer])
Expand Down
1 change: 0 additions & 1 deletion cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ const std::unordered_set<std::string> kBlackList = {
"split_part",
"factorial",
"from_json",
"json_array_length",
"trunc",
"sequence",
"approx_percentile",
Expand Down
4 changes: 2 additions & 2 deletions ep/build-velox/src/get_velox.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

set -exu

VELOX_REPO=https://github.com/oap-project/velox.git
VELOX_BRANCH=2024_12_23
VELOX_REPO=https://github.com/WangGuangxin/velox.git
VELOX_BRANCH=2024_12_23-json_array_length
VELOX_HOME=""

OS=`uname -s`
Expand Down
Loading