[Shims] Fix the code style issue of prepareWrite #8316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
JkSelf
approved these changes
Dec 24, 2024
zhztheplayer
approved these changes
Dec 24, 2024
| conf | ||
| .asInstanceOf[JobConf] | ||
| .setOutputFormat(classOf[org.apache.orc.mapred.OrcOutputFormat[OrcStruct]]) | ||
|
|
||
| if ("true" == sparkSession.sparkContext.getLocalProperty("isNativeApplicable")) { |
There was a problem hiding this comment.
This might be subjective though it's a bit weird to see these Yoda conditions in our Scala code base. Perhaps we could invert them (in future).
rui-mo
force-pushed
the
wip_clean_writer
branch
from
3dff1bf to
09e3ec2
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
force-pushed
the
wip_clean_writer
branch
from
09e3ec2 to
ef0c44c
Compare
|
Run Gluten Clickhouse CI on x86 |
2 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
rui-mo
force-pushed
the
wip_clean_writer
branch
from
ef0c44c to
e115eb9
Compare
|
Run Gluten Clickhouse CI on x86 |
rui-mo
changed the title
yikf
pushed a commit
to yikf/incubator-gluten
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the code style issue of 'prepareWrite' in Spark 3.2 and 3.3 shims.
How was this patch tested?
CI