Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA][MINOR] Change the issueRegexp to (?:#|GLUTEN-)(\d+) from the vcs.xml #8329

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

yikf
Copy link
Contributor

@yikf yikf commented Dec 24, 2024

What changes were proposed in this pull request?

This PR aims to change the issueRegexp to (?:#|GLUTEN-)(\d+) from the vcs.xml. It seems that the GLUTEN-(\d+) is not working if the issueRegexp is #(\d+)|GLUTEN-(\d+)[1].

[1] https://www.jetbrains.com/help/idea/handling-issues.html#example

How was this patch tested?

manual tests.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@yikf
Copy link
Contributor Author

yikf commented Dec 24, 2024

@zhztheplayer @merrily01 Could you please take a look if you find a time, thanks!

@zhztheplayer
Copy link
Member

zhztheplayer commented Dec 25, 2024

@yikf Thanks for working on this.

Can we try changing to (?:#|GLUTEN-)(\d+)? It's working locally from my side.

@yikf
Copy link
Contributor Author

yikf commented Dec 25, 2024

@yikf Thanks for working on this.

Can we try changing to (?:#|GLUTEN-)(\d+)? It's working locally from my side.

@zhztheplayer It work fine, thanks.

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer
Copy link
Member

Would you update PR title as well? Thanks.

@yikf yikf changed the title [INFRA][MINOR] Remove the issueRegexp of the GLUTEN-(\d+) from the vcs.xml. [INFRA][MINOR] Change the issueRegexp to (?:#|GLUTEN-)(\d+) from the vcs.xml. Dec 25, 2024
@yikf
Copy link
Contributor Author

yikf commented Dec 25, 2024

Would you update PR title as well? Thanks.

Sure, updated.

@zhztheplayer zhztheplayer merged commit 56b8514 into apache:main Dec 25, 2024
6 checks passed
@yikf yikf deleted the vcs-minor branch December 25, 2024 06:02
@zhztheplayer zhztheplayer changed the title [INFRA][MINOR] Change the issueRegexp to (?:#|GLUTEN-)(\d+) from the vcs.xml. [INFRA][MINOR] Change the issueRegexp to (?:#|GLUTEN-)(\d+) from the vcs.xml Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants