[GLUTEN-8327][CORE][Part-1] Rename GlutenConfig.getConf to GlutenConfig.get
#8395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
yikf
changed the title
GlutenConfig.getConf to GlutenConfig.get
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
Jan 2, 2025
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
changed the title
GlutenConfig.getConf to GlutenConfig.getGlutenConfig.getConf to GlutenConfig.get
|
@baibaichen Have you confirm the performance with this pr? |
|
@PHILO-HE |
|
I verify this PR. it's ok |
5 tasks
yikf
changed the title
GlutenConfig.getConf to GlutenConfig.getGlutenConfig.getConf to GlutenConfig.get
baibaichen
changed the title
GlutenConfig.getConf to GlutenConfig.getGlutenConfig.getConf to GlutenConfig.get
@baibaichen, thanks for your confirmation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR picks the performance insensitive changes from the revert commit back.
This PR aims to rename
GlutenConfig.getConftoGlutenConfig.getHow was this patch tested?
GA