[CORE] Enlarge defaultRecursionLimit by pre-loading the protobuf class

[PHILO-HE]

What changes were proposed in this pull request?

We previously introduced custom protobuf dependency with only defaultRecursionLimit enlarged to avoid the limit is hit for deeply nested plans (one user reported this issue). It is not easy to upgrade this dependency since it requires local build and then publishing the jar to maven repo.

With this change, we can remove the custom protobuf dependency for easily upgrading protobuf when needed.

How was this patch tested?

Verified by local remote debug.

[github-actions]

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

• Other pull requests

[PHILO-HE]

@FelixYBW, @zhztheplayer

[github-actions]

Run Gluten Clickhouse CI on x86

[zhouyuan]

related
#3814
protocolbuffers/protobuf#13301

[FelixYBW]

incubator-gluten/gluten-iceberg/pom.xml

Line 84 in 18f1510

<scope>test</scope>

set to "provide"
several other places also need to be updated

[FelixYBW]

incubator-gluten/package/pom.xml

Line 356 in 18f1510

<ignoreClass>com.google.protobuf.*</ignoreClass>

Remove?

[github-actions]

Run Gluten Clickhouse CI on x86

[PHILO-HE]

incubator-gluten/gluten-iceberg/pom.xml

Line 84 in 18f1510

<scope>test</scope>

set to "provide" several other places also need to be updated

@FelixYBW, I just removed protobuf from iceberg & hudi module as it is not really used, and changed the scope to provided for delta module.

[PHILO-HE]

incubator-gluten/package/pom.xml

Line 356 in 18f1510

<ignoreClass>com.google.protobuf.*</ignoreClass>

Remove?

Yes, seems we can remove it. Let's see CI feedback.

[FelixYBW]

Where is the code to modify protobuf and build customized version? Is it manually upload to mvn repo?

[PHILO-HE]

Where is the code to modify protobuf and build customized version? Is it manually upload to mvn repo?

@FelixYBW , the code is maintained in my personal repo: https://github.com/PHILO-HE/protobuf/tree/v3.23.4-0.

Yes, we manually did that.
We firstly obtained a jar by building protobuf from source at local, then go through maven's jar publish process to make it available to download when building gluten.

[FelixYBW]

@FelixYBW , the code is maintained in my personal repo: PHILO-HE/protobuf@v3.23.4-0.

Yes, we manually did that. We firstly obtained a jar by building protobuf from source at local, then go through maven's jar publish process to make it available to download when building gluten.

Thank you for the PR! manually doing this definitely isn't a right way. Glad we fixed it.