Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[format] Unify name from target to destination #588

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Thespica
Copy link
Contributor

Reason for this PR

close #587

notice that there are still a lots of target in scala code(or documentation), maybe we should unify them too, or remain them?

What changes are included in this PR?

rename target to destination for AdjListType in proto and concepts.

Are these changes tested?

Are there any user-facing changes?

No, cause protobuf is still under development.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thespica Thespica merged commit 0003242 into apache:main Aug 12, 2024
3 checks passed
@Thespica Thespica deleted the unify-format-name branch August 12, 2024 10:13
acezen pushed a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[format] Unify name from target to destination
2 participants