[TOREE-556] Support Scala 2.13 #218
Conversation
pan3793
force-pushed
the
PR_199
branch
2 times, most recently
from
7d29aae
to
2178e20
Compare
|
@pan3793 what is the status of this pr? |
|
@lresende I remember the |
|
Thank you for the updates @pan3793 I did not do much testing, but updated my env to spark 3.4.3 + scala 13 and at least it connects and establishes a spark session... will try to spend more time on validation during the week. |
| @@ -43,7 +50,6 @@ ThisBuild / scalacOptions ++= Seq( | |||
| "-deprecation", | |||
| "-unchecked", | |||
| "-feature", | |||
| "-Xfatal-warnings", | |||
There was a problem hiding this comment.
To make the code support both Scala 2.12 and 2.13, we have to use some deprecated Scala API, so this scalac flag must be disabled.
object JavaConverters in package collection is deprecated (since 2.13.0): Use `scala.jdk.CollectionConverters` instead
| @@ -16,4 +16,6 @@ | |||
| */ | |||
| resolvers += Resolver.sonatypeRepo("releases") | |||
|
|
|||
| addCompilerPlugin("org.scalamacros" % "paradise" % "2.1.0" cross CrossVersion.full) | |||
| if (scalaBinaryVersion.value == "2.12") { | |||
| addCompilerPlugin("org.scalamacros" % "paradise" % "2.1.1" cross CrossVersion.full) | |||
There was a problem hiding this comment.
https://github.com/scalamacros/paradise
In Scala 2.13, the plugin's functionality has been included in the compiler directly under the -Ymacro-annotations flag.
| lazy val scala213 = "2.13.8" | ||
| lazy val defaultScalaVersion = sys.env.get("SCALA_VERSION") match { | ||
| case Some("2.12") => scala212 | ||
| case _ => scala213 |
There was a problem hiding this comment.
I make Scala 2.13 as the default version
|
@lresende this PR is ready to review now. |
|
also cc @requaos |
|
kindly ping @lresende ~ |
Co-authored-by: Neil Skinner [email protected]
Co-authored-by: Cheng Pan [email protected]
This PR is based on #199, and makes the project compatible with both Scala 2.12 and 2.13.
Usage:
or
or
CI is updated to cover both Scala 2.12 and 2.13 tests. I also tested some basic functionalities locally with the docker environment.