Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: Fix PipeWriteBackSink using toTPipeTransferReq causing NPE due to uninitialized buffer #14672

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

luoluoyuyu
Copy link
Contributor

Description

As the title said


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Comment on lines 108 to 113
SESSION_MANAGER.supplySession(
session,
AuthorityChecker.SUPER_USER,
ZoneId.systemDefault(),
IoTDBConstant.ClientVersion.V_1_0);
SESSION_MANAGER.registerSession(session);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove on close

@SteveYurongSu SteveYurongSu self-assigned this Jan 10, 2025
@luoluoyuyu luoluoyuyu marked this pull request as draft January 13, 2025 04:22
@luoluoyuyu luoluoyuyu marked this pull request as ready for review January 13, 2025 09:22
@SteveYurongSu SteveYurongSu merged commit f129298 into apache:master Jan 14, 2025
34 of 35 checks passed
JackieTien97 pushed a commit that referenced this pull request Jan 25, 2025
…to uninitialized buffer (#14672)

(cherry picked from commit f129298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants