-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-8413 Use the new Azure SDK in the Azure Segment Store #1748
Conversation
…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreServiceTest.java
@ierandra, the build fails with the following error in Oak Segment Azure: |
@dulceanu I was using |
@ierandra, yes, the versions need to be updated so that the build passes without skipping the baseline check. |
… package versions
Now |
@dulceanu I fixed all the tests. build should be ok now. |
This doesn't seem to compile (after applying the diff to oak trunk):
...etc... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1748 (comment)
…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java
@reschke I updated the PR with changes from apache/jackrabbit-oak trunk and should be fine now |
It does indeed; thanks. |
This looks a bit weird:
are we exporting these packages? This looks wrong...:
|
</Export-Package> | ||
<Embed-Dependency> | ||
azure-storage, | ||
azure-keyvault-core, | ||
azure-core, | ||
azure-identity, | ||
azure-json, | ||
azure-xml, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we embedding the new SDK? Why?
(We embedded the old one due to the Guava dependency issue, but this should not be needed here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried without and I got the following error at build:
[ERROR] Bundle oak-segment-azure:1.71-ierandra-T20241104112150-3ccdb109e0 is importing package(s) com.azure.xml in start level 15 but no bundle is exporting these for that start level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the oak-it-osgi tests? In which case we may have to add the dependency there.
Opened https://issues.apache.org/jira/browse/OAK-11236 - the embedding/exporting issues started earlier. |
…refix and missing metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this adds many new files, please make sure that all of them just use LF as line ends (otherwise fixing this will cause ugly diffs), and check with "-Prat" that all licenses are ok.
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/package-info.java
Show resolved
Hide resolved
The build on my machine fails because of baseline plugin
|
…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only looking into POMs here.
It is unclear why apparently apparently all new dependencies get embedded. What's the reason for that?
As I mention in my previous comment if I don't do it if fails at build phase for CQ: |
@smiroslav I fixed all the comments. could you please take a look? |
Thanks @ierandra I am having a look. In the meantime, I started the build, and it failed.
|
@smiroslav I just run the command you mentioned ( |
@ierandra the build first failed in jenkins |
https://github.com/apache/jackrabbit-oak/actions/runs/12028412044/job/34597299155?pr=1748
|
…to issue/OAK-8413
…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreServiceTest.java
…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileTest.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/fixture/SegmentAzureFixture.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/spi/persistence/split/SplitPersistenceBlobTest.java
* OAK-8413 Use the new Azure SDK in the Azure Segment Store * OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure package versions * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove debug logging * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix and missing metadata * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * Updates from master
* OAK-8413 Use the new Azure SDK in the Azure Segment Store * OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure package versions * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove debug logging * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix and missing metadata * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * Updates from master
* OAK-8413 Use the new Azure SDK in the Azure Segment Store * OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure package versions * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove debug logging * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix and missing metadata * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * Updates from master
…ache#1748)" This reverts commit a8fe2ac.
* OAK-8413 Use the new Azure SDK in the Azure Segment Store * OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure package versions * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove debug logging * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review fixes * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix and missing metadata * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootPrefix issue * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge * OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests * Updates from master
No description provided.