Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11399: Remove usage of Guava io.BaseEncoding #1992

Merged
merged 5 commits into from
Jan 18, 2025
Merged

OAK-11399: Remove usage of Guava io.BaseEncoding #1992

merged 5 commits into from
Jan 18, 2025

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Jan 16, 2025

No description provided.

@reschke reschke self-assigned this Jan 16, 2025
@reschke reschke marked this pull request as draft January 16, 2025 14:21
Copy link

github-actions bot commented Jan 16, 2025

Commit-Check ❌

Commit rejected by Commit-Check.                                  
                                                                  
  (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)    (c).-.(c)  
   / ._. \      / ._. \      / ._. \      / ._. \      / ._. \   
 __\( C )/__  __\( H )/__  __\( E )/__  __\( C )/__  __\( K )/__ 
(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)(_.-/'-'\-._)
   || E ||      || R ||      || R ||      || O ||      || R ||   
 _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._  _.' '-' '._ 
(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)(.-./`-´\.-.)
 `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´  `-´     `-´ 
                                                                  
Commit rejected.                                                  
                                                                  
Type message check failed => Merge branch 'trunk' into OAK-11399

 
It doesn't match regex: ^OAK-\d+:?\s\S+.*
The commit message must start with 'OAK-<ID>[:] ' followed by some descriptive text
Suggest: Please check your commit message whether it matches above regex

@reschke reschke marked this pull request as ready for review January 17, 2025 11:57
@@ -237,7 +244,7 @@ public String getReference(@NotNull String blobId) {
Mac mac = Mac.getInstance(ALGORITHM);
mac.init(new SecretKeySpec(getReferenceKey(), ALGORITHM));
byte[] hash = mac.doFinal(blobId.getBytes("UTF-8"));
return blobId + ':' + BaseEncoding.base32Hex().encode(hash);
return ':' + BASE32ENCODER.encodeToString(hash);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be: return blobId + ':' +...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, so much for opening PRs while tests are still running, and making last-second changes.

@reschke reschke merged commit c6bb208 into trunk Jan 18, 2025
1 of 3 checks passed
@reschke reschke deleted the OAK-11399 branch January 18, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants