-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-11399: Remove usage of Guava io.BaseEncoding #1992
Conversation
Commit-Check ❌
|
oak-blob/src/main/java/org/apache/jackrabbit/oak/spi/blob/AbstractBlobStore.java
Outdated
Show resolved
Hide resolved
@@ -237,7 +244,7 @@ public String getReference(@NotNull String blobId) { | |||
Mac mac = Mac.getInstance(ALGORITHM); | |||
mac.init(new SecretKeySpec(getReferenceKey(), ALGORITHM)); | |||
byte[] hash = mac.doFinal(blobId.getBytes("UTF-8")); | |||
return blobId + ':' + BaseEncoding.base32Hex().encode(hash); | |||
return ':' + BASE32ENCODER.encodeToString(hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be: return blobId + ':' +...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, so much for opening PRs while tests are still running, and making last-second changes.
Quality Gate passedIssues Measures |
No description provided.