-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor and test the use of the anyone
keyword when sharing with JMAP
#2491
Conversation
|
the 5th commit comes with an open question, here is the spec:
a sharee can see its own rights (as specified by the doc), but currently cannot see the rights granted to |
...ls/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/MailboxSetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/Rights.scala
Show resolved
Hide resolved
...-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ISSUE-5314] integration test - a sharee should see the rights granted to 'anyone'
What for? I am rather against it as only 'p' right is visible.
Let's keep scope small. And not do that.
...ls/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/MailboxSetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
...ls/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/MailboxSetUpdatePerformer.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxSet.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxSet.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxSet.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxSet.scala
Outdated
Show resolved
Hide resolved
c375b23
to
2421997
Compare
tackling issue #5314