Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and test the use of the anyone keyword when sharing with JMAP #2491

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

florentos17
Copy link
Contributor

tackling issue #5314

@florentos17
Copy link
Contributor Author

  • 1st commit: when implementing frontend support for subbaddressing, i had issues with a plain serverFail error without any description. it was actually a DifferentDomainException, the error handling can now pick it up ;
  • 2nd & 3rd commits: some refactorings to be able to use anyone in a special entry key
  • 4th commit: the integration test that show that a mailbox can now be shared with anyone

@florentos17
Copy link
Contributor Author

florentos17 commented Nov 6, 2024

the 5th commit comes with an open question, here is the spec:

`rights` of type `Rights`. The owner can see the full rights, but sharee MUST only see their rights if they do not have the administer right on the mailbox.
Sharee without administer right MUST NOT be able to see another SHAREE rights.

a sharee can see its own rights (as specified by the doc), but currently cannot see the rights granted to anyone. to me it would make sense to make this visible to the sharee. what do you think ?

Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ISSUE-5314] integration test - a sharee should see the rights granted to 'anyone'

What for? I am rather against it as only 'p' right is visible.

Let's keep scope small. And not do that.

@chibenwa chibenwa marked this pull request as ready for review November 10, 2024 00:20
@chibenwa chibenwa merged commit d014a4b into apache:master Nov 13, 2024
1 check passed
@florentos17 florentos17 deleted the Anyone-Keyword-In-Jmap branch November 13, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants