KAFKA-17757: Remove Utils.mkEntry #17488
Open
+1,951
−2,050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
streams
core
mingyen066
changed the title
mingyen066
changed the title
mingyen066
changed the title
mingyen066
changed the title
mingyen066
changed the title
|
@mingyen066 Please check the CI |
chia7712
reviewed
Oct 18, 2024
| @@ -94,8 +93,8 @@ public void testFlushFailureWhenWriteToSecondaryStoreFailsForTombstoneOffsets() | |||
| AtomicReference<Throwable> callbackError = new AtomicReference<>(); | |||
|
|
|||
| Future<Void> setFuture = offsetBackingStore.set(getSerialisedOffsets(mkMap( | |||
| mkEntry(OFFSET_KEY_SERIALIZED, null), | |||
There was a problem hiding this comment.
this case needs to have map carrying null value, so you can add helper for this case specifically
There was a problem hiding this comment.
Since there are still many tests using mkEntry to create entries with null values, this PR will migrate all the code that can be converted to use Map.entry. The remaining code that still uses mkEntry will only for creating null entries.
|
@mingyen066 please fix conflicts |
mingyen066
force-pushed
the
KAFKA-17758-Replace-Utils.mkMap-and-UtilsmkEntry-with-Map.entry-and-Map.ofEntries
branch
from
5318b5b
to
b453825
Compare
|
Hi @chia7712, sorry for the late reply. I've migrated all the mkEntry usages to Map.entry, except for those used to create entries with null values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: Since there are still many tests using mkEntry to create entries with null values, this PR will migrate all the code that can be converted to use Map.entry. The remaining code that still uses mkEntry will only for creating null entries.
Removes
Utils#mkMapandUtils#mkEntryas JDK 9+ allowsMap.ofEntriesandMap.entryfor creating immutable map.Utils#mkMapwill be handled in KAFKA-17820Committer Checklist (excluded from commit message)