MINOR: Convert DynamicBrokerReconfigurationTest to KRaft #17905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
chia7712
approved these changes
Nov 26, 2024
|
@cmccabe Could you please check the failed tests? |
|
or the test can be disabled temporarily and I will file a jira to trace it |
cmccabe
force-pushed
the
cmccabe_remove_zk_only_tests_in_dynamic_broker_reconfiguration_test
branch
3 times, most recently
from
355dfd3 to
4a5d199
Compare
cmccabe
force-pushed
the
cmccabe_remove_zk_only_tests_in_dynamic_broker_reconfiguration_test
branch
from
4a5d199 to
c6eac28
Compare
chia7712
reviewed
Nov 28, 2024
| @@ -852,7 +840,8 @@ class DynamicBrokerReconfigurationTest extends QuorumTestHarness with SaslSetup | |||
| "", mayReceiveDuplicates = false) | |||
| verifyThreadPoolResize(SocketServerConfigs.NUM_NETWORK_THREADS_CONFIG, config.numNetworkThreads, | |||
| networkThreadPrefix, mayReceiveDuplicates = true) | |||
| verifyThreads("data-plane-kafka-socket-acceptor-", config.listeners.size) | |||
| System.out.println("config.listeners = " + config.listeners) | |||
There was a problem hiding this comment.
Could you please remove this line?
cmccabe
deleted the
cmccabe_remove_zk_only_tests_in_dynamic_broker_reconfiguration_test
branch
I fixed it by reducing |
chia7712
reviewed
Nov 29, 2024
| def testThreadPoolResize(groupProtocol: String): Unit = { | ||
| @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) | ||
| @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) | ||
| def testThreadPoolResize(quorum: String, groupProtocol: String): Unit = { |
There was a problem hiding this comment.
This gets flaky and I open https://issues.apache.org/jira/browse/KAFKA-18123 to fix it.
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Nov 30, 2024
Convert testUncleanLeaderElectionEnable and testMetricsReporterUpdate to KRaft. Remove testAdvertisedListenerUpdate, testAddRemoveSslListener, testAddRemoveSaslListeners since we no longer support dynamically adding or removing network listeners when in KRaft mode. Make TestUtils.ensureConsistentKRaftMetadata robust against brokers that don't have sharedServer.loader initialized yet (or have shut down). Reviewers: Chia-Ping Tsai <[email protected]>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
Convert testUncleanLeaderElectionEnable and testMetricsReporterUpdate to KRaft. Remove testAdvertisedListenerUpdate, testAddRemoveSslListener, testAddRemoveSaslListeners since we no longer support dynamically adding or removing network listeners when in KRaft mode. Make TestUtils.ensureConsistentKRaftMetadata robust against brokers that don't have sharedServer.loader initialized yet (or have shut down). Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert testUncleanLeaderElectionEnable and testMetricsReporterUpdate to KRaft.
Remove testAdvertisedListenerUpdate, testAddRemoveSslListener, testAddRemoveSaslListeners since we no longer support dynamically adding or removing network listeners when in KRaft mode.
Make TestUtils.ensureConsistentKRaftMetadata robust against brokers that don't have sharedServer.loader initialized yet (or have shut down).