MINOR: remove some obsolete zk tests #17913
Merged
+17
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mumrah
reviewed
Nov 22, 2024
| @nowarn("cat=deprecation") | ||
| @ParameterizedTest | ||
| @ValueSource(strings = Array("zk")) | ||
| def testMessageFormatVersionChange(quorum: String): Unit = { |
There was a problem hiding this comment.
Why didn't we port this one to KRaft? Is it because we are always on record version 2 now?
There was a problem hiding this comment.
correct. we don't support record version 0 and 1 on kraft (never did)
Remove all zk tests from MetricsTest.scala, CreateTopicsRequestTest.scala, DynamicConfigChangeTest.scala, MetadataRequestTest.scala, ListOffsetsIntegrationTest.scala, and ServerShutdownTest.scala. Convert CreateTopicsRequestTest.testCreateTopicsRequestVersions to KRaft.
cmccabe
force-pushed
the
cmccabe_remove_zk_tests_nov22
branch
from
5fc673b
to
3dc71a6
Compare
chia7712
approved these changes
Nov 23, 2024
| @@ -327,22 +253,6 @@ class DynamicConfigChangeTest extends KafkaServerTestHarness { | |||
| } finally { | |||
| admin.close() | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
Could you please also remove if (isKRaftTest()) for this test? It is redundant now.
| @@ -152,10 +142,6 @@ class ServerShutdownTest extends KafkaServerTestHarness { | |||
| shutdownBroker() | |||
| shutdownKRaftController() | |||
| verifyCleanShutdownAfterFailedStartup[CancellationException] | |||
| } else { | |||
There was a problem hiding this comment.
ditto. could you please remove isKRaftTest?
3 tasks
|
The failed test is being tracked in KAFKA-18078. I'll create a follow-up to clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all zk tests from MetricsTest.scala,
CreateTopicsRequestTest.scala, DynamicConfigChangeTest.scala, MetadataRequestTest.scala.
Convert CreateTopicsRequestTest.testCreateTopicsRequestVersions to KRaft.