Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17997: Remove deprecated config log.message.timestamp.difference.max.ms #17928

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

HyunSangHan
Copy link

For improving message timestamp validation,

  1. I have removed the related code for log.message.timestamp.difference.max.ms.
  2. I have also updated the update notes to reflect this change.

As a result, starting from Kafka version 4.0.0, the log.message.timestamp.difference.max.ms configuration will no longer be supported.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added core Kafka Broker storage Pull requests that target the storage module clients labels Nov 24, 2024
@HyunSangHan HyunSangHan changed the title [KAFKA-17997] Remove deprecated config log.message.timestamp.difference.max.ms KAFKA-17997: Remove deprecated config log.message.timestamp.difference.max.ms Nov 24, 2024
Copy link
Contributor

@divijvaidya divijvaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I am starting the test suite run. Will merge in after it is successful.

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyunSangHan Could you please remove log.message.timestamp.difference.max.ms from configuration.html?

https://github.com/apache/kafka/blob/trunk/docs/configuration.html#L131

@HyunSangHan
Copy link
Author

@chia7712
Thank you for feedback! I removed it. 0de0768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients core Kafka Broker storage Pull requests that target the storage module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants